Browse Source

fix indent and add spec

stvnrlly 10 years ago
parent
commit
f1285737e0
2 changed files with 13 additions and 2 deletions
  1. 2 2
      app/models/agents/slack_agent.rb
  2. 11 0
      spec/models/agents/slack_agent_spec.rb

+ 2 - 2
app/models/agents/slack_agent.rb

@@ -72,9 +72,9 @@ module Agents
       incoming_events.each do |event|
         opts = interpolated(event)
         if /^:/.match(opts[:icon])
-            slack_notifier.ping opts[:message], channel: opts[:channel], username: opts[:username], icon_emoji: opts[:icon]
+          slack_notifier.ping opts[:message], channel: opts[:channel], username: opts[:username], icon_emoji: opts[:icon]
         else
-            slack_notifier.ping opts[:message], channel: opts[:channel], username: opts[:username], icon_url: opts[:icon]
+          slack_notifier.ping opts[:message], channel: opts[:channel], username: opts[:username], icon_url: opts[:icon]
         end
       end
     end

+ 11 - 0
spec/models/agents/slack_agent_spec.rb

@@ -33,6 +33,17 @@ describe Agents::SlackAgent do
       @checker.options['channel'] = nil
       expect(@checker).not_to be_valid
     end
+
+    it "should allow an icon" do
+      @checker.options['icon_emoji'] = nil
+      expect(@checker).to be_valid
+      @checker.options['icon_emoji'] = ":something:"
+      expect(@checker).to be_valid
+      @checker.options['icon_url'] = "http://something.com/image.png"
+      expect(@checker).to be_valid
+      @checker.options['icon_emoji'] = "something"
+      expect(@checker).to be_valid
+    end
   end
 
   describe "#receive" do