Browse Source

Update for rspec3 rails_helpers config, fix shoulda matchers

Dustin Miller 9 years ago
parent
commit
c5766d2086
100 changed files with 124 additions and 122 deletions
  1. 1 1
      app/concerns/sortable_events.rb
  2. 1 1
      spec/concerns/dry_runnable_spec.rb
  3. 1 1
      spec/concerns/form_configurable_spec.rb
  4. 1 1
      spec/concerns/inheritance_tracking_spec.rb
  5. 1 1
      spec/concerns/liquid_droppable_spec.rb
  6. 1 1
      spec/concerns/liquid_interpolatable_spec.rb
  7. 1 1
      spec/concerns/long_runnable_spec.rb
  8. 3 3
      spec/concerns/sortable_events_spec.rb
  9. 1 1
      spec/controllers/agents_controller_spec.rb
  10. 1 1
      spec/controllers/concerns/sortable_table_spec.rb
  11. 1 1
      spec/controllers/events_controller_spec.rb
  12. 1 1
      spec/controllers/jobs_controller_spec.rb
  13. 1 1
      spec/controllers/logs_controller_spec.rb
  14. 1 1
      spec/controllers/omniauth_callbacks_controller_spec.rb
  15. 1 1
      spec/controllers/scenario_imports_controller_spec.rb
  16. 1 1
      spec/controllers/scenarios_controller_spec.rb
  17. 1 1
      spec/controllers/services_controller_spec.rb
  18. 1 1
      spec/controllers/user_credentials_controller_spec.rb
  19. 1 1
      spec/controllers/web_requests_controller_spec.rb
  20. 1 1
      spec/helpers/application_helper_spec.rb
  21. 1 1
      spec/helpers/dot_helper_spec.rb
  22. 1 1
      spec/helpers/jobs_helper_spec.rb
  23. 1 1
      spec/helpers/markdown_helper_spec.rb
  24. 1 1
      spec/helpers/scenario_helper_spec.rb
  25. 1 1
      spec/lib/agent_runner_spec.rb
  26. 1 1
      spec/lib/agents_exporter_spec.rb
  27. 1 1
      spec/lib/delayed_job_worker_spec.rb
  28. 1 1
      spec/lib/huginn_scheduler_spec.rb
  29. 1 1
      spec/lib/liquid_migrator_spec.rb
  30. 3 3
      spec/lib/location_spec.rb
  31. 1 1
      spec/lib/utils_spec.rb
  32. 1 1
      spec/models/agent_log_spec.rb
  33. 3 3
      spec/models/agent_spec.rb
  34. 1 1
      spec/models/agents/adioso_agent_spec.rb
  35. 1 1
      spec/models/agents/basecamp_agent_spec.rb
  36. 1 1
      spec/models/agents/change_detector_agent_spec.rb
  37. 1 1
      spec/models/agents/commander_agent_spec.rb
  38. 1 1
      spec/models/agents/data_output_agent_spec.rb
  39. 1 1
      spec/models/agents/de_duplication_agent_spec.rb
  40. 1 1
      spec/models/agents/delay_agent_spec.rb
  41. 1 1
      spec/models/agents/dropbox_file_url_agent_spec.rb
  42. 1 1
      spec/models/agents/dropbox_watch_agent_spec.rb
  43. 1 1
      spec/models/agents/email_agent_spec.rb
  44. 1 1
      spec/models/agents/email_digest_agent_spec.rb
  45. 1 1
      spec/models/agents/event_formatting_agent_spec.rb
  46. 1 1
      spec/models/agents/evernote_agent_spec.rb
  47. 2 2
      spec/models/agents/ftpsite_agent_spec.rb
  48. 1 1
      spec/models/agents/gap_detector_agent_spec.rb
  49. 1 1
      spec/models/agents/google_calendar_publish_agent_spec.rb
  50. 1 1
      spec/models/agents/growl_agent_spec.rb
  51. 1 1
      spec/models/agents/hipchat_agent_spec.rb
  52. 1 1
      spec/models/agents/human_task_agent_spec.rb
  53. 1 1
      spec/models/agents/imap_folder_agent_spec.rb
  54. 1 1
      spec/models/agents/jabber_agent_spec.rb
  55. 1 1
      spec/models/agents/java_script_agent_spec.rb
  56. 1 1
      spec/models/agents/jira_agent_spec.rb
  57. 1 1
      spec/models/agents/mqtt_agent_spec.rb
  58. 1 1
      spec/models/agents/pdf_agent_spec.rb
  59. 1 1
      spec/models/agents/peak_detector_agent_spec.rb
  60. 1 1
      spec/models/agents/post_agent_spec.rb
  61. 1 1
      spec/models/agents/public_transport_agent_spec.rb
  62. 1 1
      spec/models/agents/pushbullet_agent_spec.rb
  63. 1 1
      spec/models/agents/pushover_agent_spec.rb
  64. 1 1
      spec/models/agents/rss_agent_spec.rb
  65. 1 1
      spec/models/agents/scheduler_agent_spec.rb
  66. 1 1
      spec/models/agents/sentiment_agent_spec.rb
  67. 1 1
      spec/models/agents/shell_command_agent_spec.rb
  68. 1 1
      spec/models/agents/slack_agent_spec.rb
  69. 1 1
      spec/models/agents/stubhub_agent_spec.rb
  70. 1 1
      spec/models/agents/translation_agent_spec.rb
  71. 1 1
      spec/models/agents/trigger_agent_spec.rb
  72. 1 1
      spec/models/agents/tumblr_publish_agent_spec.rb
  73. 1 1
      spec/models/agents/twilio_agent_spec.rb
  74. 1 1
      spec/models/agents/twitter_publish_agent_spec.rb
  75. 1 1
      spec/models/agents/twitter_search_agent_spec.rb
  76. 1 1
      spec/models/agents/twitter_stream_agent_spec.rb
  77. 1 1
      spec/models/agents/twitter_user_agent_spec.rb
  78. 1 1
      spec/models/agents/user_location_agent_spec.rb
  79. 1 1
      spec/models/agents/weather_agent_spec.rb
  80. 1 1
      spec/models/agents/webhook_agent_spec.rb
  81. 1 1
      spec/models/agents/website_agent_spec.rb
  82. 1 1
      spec/models/agents/weibo_publish_agent_spec.rb
  83. 1 1
      spec/models/agents/weibo_user_agent_spec.rb
  84. 1 1
      spec/models/agents/witai_agent_spec.rb
  85. 1 1
      spec/models/agents/wunderlist_agent_spec.rb
  86. 1 1
      spec/models/concerns/oauthable.rb
  87. 1 1
      spec/models/event_spec.rb
  88. 1 1
      spec/models/scenario_import_spec.rb
  89. 1 1
      spec/models/scenario_spec.rb
  90. 1 1
      spec/models/service_spec.rb
  91. 8 8
      spec/models/user_credential_spec.rb
  92. 4 4
      spec/models/users_spec.rb
  93. 1 1
      spec/presenters/form_configurable_agent_presenter_spec.rb
  94. 7 5
      spec/rails_helper.rb
  95. 1 1
      spec/routing/webhooks_controller_spec.rb
  96. 1 1
      spec/support/shared_examples/agent_controller_concern.rb
  97. 1 1
      spec/support/shared_examples/email_concern.rb
  98. 1 1
      spec/support/shared_examples/has_guid.rb
  99. 2 2
      spec/support/shared_examples/liquid_interpolatable.rb
  100. 1 1
      spec/support/shared_examples/web_request_concern.rb

+ 1 - 1
app/concerns/sortable_events.rb

@@ -11,7 +11,7 @@ module SortableEvents
 
   module ClassMethods
     def can_order_created_events!
-      raise if cannot_create_events?
+      raise 'Cannot order events for agent that cannot create events' if cannot_create_events?
       prepend AutomaticSorter
     end
 

+ 1 - 1
spec/concerns/dry_runnable_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require 'rails_helper'
 
 describe DryRunnable do
   class Agents::SandboxedAgent < Agent

+ 1 - 1
spec/concerns/form_configurable_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require 'rails_helper'
 
 describe FormConfigurable do
   class Agent1

+ 1 - 1
spec/concerns/inheritance_tracking_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require 'rails_helper'
 require 'inheritance_tracking'
 
 describe InheritanceTracking do

+ 1 - 1
spec/concerns/liquid_droppable_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require 'rails_helper'
 
 describe LiquidDroppable do
   before do

+ 1 - 1
spec/concerns/liquid_interpolatable_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require 'rails_helper'
 require 'nokogiri'
 
 describe LiquidInterpolatable::Filters do

+ 1 - 1
spec/concerns/long_runnable_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require 'rails_helper'
 
 describe LongRunnable do
   class LongRunnableAgent < Agent

+ 3 - 3
spec/concerns/sortable_events_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require 'rails_helper'
 
 describe SortableEvents do
   let(:agent_class) {
@@ -152,7 +152,7 @@ describe SortableEvents do
             passive_agent_class.class_eval do
               can_order_created_events!
             end
-          }.to raise_error
+          }.to raise_error('Cannot order events for agent that cannot create events')
         end
 
         it 'should work if called from an Agent that can create events' do
@@ -160,7 +160,7 @@ describe SortableEvents do
             active_agent_class.class_eval do
               can_order_created_events!
             end
-          }.not_to raise_error
+          }.not_to raise_error()
         end
       end
 

+ 1 - 1
spec/controllers/agents_controller_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require 'rails_helper'
 
 describe AgentsController do
   def valid_attributes(options = {})

+ 1 - 1
spec/controllers/concerns/sortable_table_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require 'rails_helper'
 
 describe SortableTable do
   class SortableTestController

+ 1 - 1
spec/controllers/events_controller_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require 'rails_helper'
 
 describe EventsController do
   before do

+ 1 - 1
spec/controllers/jobs_controller_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require 'rails_helper'
 
 describe JobsController do
   describe "GET index" do

+ 1 - 1
spec/controllers/logs_controller_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require 'rails_helper'
 
 describe LogsController do
   describe "GET index" do

+ 1 - 1
spec/controllers/omniauth_callbacks_controller_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require 'rails_helper'
 
 describe OmniauthCallbacksController do
   before do

+ 1 - 1
spec/controllers/scenario_imports_controller_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require 'rails_helper'
 
 describe ScenarioImportsController do
   before do

+ 1 - 1
spec/controllers/scenarios_controller_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require 'rails_helper'
 
 describe ScenariosController do
   def valid_attributes(options = {})

+ 1 - 1
spec/controllers/services_controller_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require 'rails_helper'
 
 describe ServicesController do
   before do

+ 1 - 1
spec/controllers/user_credentials_controller_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require 'rails_helper'
 
 describe UserCredentialsController do
   def valid_attributes(options = {})

+ 1 - 1
spec/controllers/web_requests_controller_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require 'rails_helper'
 
 describe WebRequestsController do
   class Agents::WebRequestReceiverAgent < Agent

+ 1 - 1
spec/helpers/application_helper_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require 'rails_helper'
 
 describe ApplicationHelper do
   describe '#icon_tag' do

+ 1 - 1
spec/helpers/dot_helper_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require 'rails_helper'
 
 describe DotHelper do
   describe "with example Agents" do

+ 1 - 1
spec/helpers/jobs_helper_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require 'rails_helper'
 
 describe JobsHelper do
   let(:job) { Delayed::Job.new }

+ 1 - 1
spec/helpers/markdown_helper_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require 'rails_helper'
 
 describe MarkdownHelper do
 

+ 1 - 1
spec/helpers/scenario_helper_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require 'rails_helper'
 
 describe ScenarioHelper do
   let(:scenario) { users(:bob).scenarios.build(name: 'Scene', tag_fg_color: '#AAAAAA', tag_bg_color: '#000000') }

+ 1 - 1
spec/lib/agent_runner_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require 'rails_helper'
 
 describe AgentRunner do
   context "without traps" do

+ 1 - 1
spec/lib/agents_exporter_spec.rb

@@ -1,6 +1,6 @@
 # encoding: utf-8
 
-require 'spec_helper'
+require 'rails_helper'
 
 describe AgentsExporter do
   describe "#as_json" do

+ 1 - 1
spec/lib/delayed_job_worker_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require 'rails_helper'
 
 describe DelayedJobWorker do
   before do

+ 1 - 1
spec/lib/huginn_scheduler_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require 'rails_helper'
 require 'huginn_scheduler'
 
 describe HuginnScheduler do

+ 1 - 1
spec/lib/liquid_migrator_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require 'rails_helper'
 
 describe LiquidMigrator do
   describe "converting JSONPath strings" do

+ 3 - 3
spec/lib/location_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require 'rails_helper'
 
 describe Location do
   let(:location) {
@@ -30,14 +30,14 @@ describe Location do
     expect(location['lat']).to eq 2.0
   end
 
-  it "has a convencience accessor for combined latitude and longitude" do
+  it "has a convenience accessor for combined latitude and longitude" do
     expect(location.latlng).to eq "2.0,3.0"
   end
 
   it "does not allow hash-style assignment" do
     expect {
       location[:lat] = 2.0
-    }.to raise_error
+    }.to raise_error(NoMethodError)
   end
 
   it "ignores invalid values" do

+ 1 - 1
spec/lib/utils_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require 'rails_helper'
 
 describe Utils do
   describe "#unindent" do

+ 1 - 1
spec/models/agent_log_spec.rb

@@ -1,5 +1,5 @@
 # -*- coding: utf-8 -*-
-require 'spec_helper'
+require 'rails_helper'
 
 describe AgentLog do
   describe "validations" do

+ 3 - 3
spec/models/agent_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require 'rails_helper'
 
 describe Agent do
   it_behaves_like WorkingHelpers
@@ -223,7 +223,7 @@ describe Agent do
         mock(Agent).find(@checker.id) { @checker }
         expect {
           Agents::SomethingSource.async_check(@checker.id)
-        }.to raise_error
+        }.to raise_error(RuntimeError)
         log = @checker.logs.first
         expect(log.message).to match(/Exception/)
         expect(log.level).to eq(4)
@@ -263,7 +263,7 @@ describe Agent do
         Agent.async_check(agents(:bob_weather_agent).id)
         expect {
           Agent.async_receive(agents(:bob_rain_notifier_agent).id, [agents(:bob_weather_agent).events.last.id])
-        }.to raise_error
+        }.to raise_error(RuntimeError)
         log = agents(:bob_rain_notifier_agent).logs.first
         expect(log.message).to match(/Exception/)
         expect(log.level).to eq(4)

+ 1 - 1
spec/models/agents/adioso_agent_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require 'rails_helper'
 
 describe Agents::AdiosoAgent do
 	before do

+ 1 - 1
spec/models/agents/basecamp_agent_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require 'rails_helper'
 require 'models/concerns/oauthable'
 
 describe Agents::BasecampAgent do

+ 1 - 1
spec/models/agents/change_detector_agent_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require 'rails_helper'
 
 describe Agents::ChangeDetectorAgent do
   def create_event(output=nil)

+ 1 - 1
spec/models/agents/commander_agent_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require 'rails_helper'
 
 describe Agents::CommanderAgent do
   let(:valid_params) {

+ 1 - 1
spec/models/agents/data_output_agent_spec.rb

@@ -1,6 +1,6 @@
 # encoding: utf-8
 
-require 'spec_helper'
+require 'rails_helper'
 
 describe Agents::DataOutputAgent do
   let(:agent) do

+ 1 - 1
spec/models/agents/de_duplication_agent_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require 'rails_helper'
 
 describe Agents::DeDuplicationAgent do
   def create_event(output=nil)

+ 1 - 1
spec/models/agents/delay_agent_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require 'rails_helper'
 
 describe Agents::DelayAgent do
   let(:agent) do

+ 1 - 1
spec/models/agents/dropbox_file_url_agent_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require 'rails_helper'
 
 describe Agents::DropboxFileUrlAgent do
   before(:each) do

+ 1 - 1
spec/models/agents/dropbox_watch_agent_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require 'rails_helper'
 
 describe Agents::DropboxWatchAgent do
   before(:each) do

+ 1 - 1
spec/models/agents/email_agent_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require 'rails_helper'
 
 describe Agents::EmailAgent do
   it_behaves_like EmailConcern

+ 1 - 1
spec/models/agents/email_digest_agent_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require 'rails_helper'
 
 describe Agents::EmailDigestAgent do
   it_behaves_like EmailConcern

+ 1 - 1
spec/models/agents/event_formatting_agent_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require 'rails_helper'
 
 describe Agents::EventFormattingAgent do
   before do

+ 1 - 1
spec/models/agents/evernote_agent_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require 'rails_helper'
 
 describe Agents::EvernoteAgent do
   class FakeEvernoteNoteStore

+ 2 - 2
spec/models/agents/ftpsite_agent_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require 'rails_helper'
 require 'time'
 
 describe Agents::FtpsiteAgent do
@@ -26,7 +26,7 @@ describe Agents::FtpsiteAgent do
 
       it "should validate the integer fields" do
         @checker.options['expected_update_period_in_days'] = "nonsense"
-        expect { @checker.save! }.to raise_error;
+        expect { @checker.save! }.to raise_error(/Invalid expected_update_period_in_days format/);
         @checker.options = @site
       end
 

+ 1 - 1
spec/models/agents/gap_detector_agent_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require 'rails_helper'
 
 describe Agents::GapDetectorAgent do
   let(:valid_params) {

+ 1 - 1
spec/models/agents/google_calendar_publish_agent_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require 'rails_helper'
 
 describe Agents::GoogleCalendarPublishAgent, :vcr do
   before do

+ 1 - 1
spec/models/agents/growl_agent_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require 'rails_helper'
 
 describe Agents::GrowlAgent do
   before do

+ 1 - 1
spec/models/agents/hipchat_agent_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require 'rails_helper'
 
 describe Agents::HipchatAgent do
   before(:each) do

+ 1 - 1
spec/models/agents/human_task_agent_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require 'rails_helper'
 
 describe Agents::HumanTaskAgent do
   before do

+ 1 - 1
spec/models/agents/imap_folder_agent_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require 'rails_helper'
 require 'time'
 
 describe Agents::ImapFolderAgent do

+ 1 - 1
spec/models/agents/jabber_agent_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require 'rails_helper'
 
 describe Agents::JabberAgent do
   let(:sent) { [] }

+ 1 - 1
spec/models/agents/java_script_agent_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require 'rails_helper'
 
 describe Agents::JavaScriptAgent do
   before do

+ 1 - 1
spec/models/agents/jira_agent_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require 'rails_helper'
 
 describe Agents::JiraAgent do
   before(:each) do

+ 1 - 1
spec/models/agents/mqtt_agent_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require 'rails_helper'
 require 'mqtt'
 require './spec/support/fake_mqtt_server'
 

+ 1 - 1
spec/models/agents/pdf_agent_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require 'rails_helper'
 
 describe Agents::PdfInfoAgent do
   let(:agent) do

+ 1 - 1
spec/models/agents/peak_detector_agent_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require 'rails_helper'
 
 describe Agents::PeakDetectorAgent do
   before do

+ 1 - 1
spec/models/agents/post_agent_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require 'rails_helper'
 require 'ostruct'
 
 describe Agents::PostAgent do

+ 1 - 1
spec/models/agents/public_transport_agent_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require 'rails_helper'
 describe Agents::PublicTransportAgent do
   before do
     valid_params = {

+ 1 - 1
spec/models/agents/pushbullet_agent_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require 'rails_helper'
 
 describe Agents::PushbulletAgent do
   before(:each) do

+ 1 - 1
spec/models/agents/pushover_agent_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require 'rails_helper'
 
 describe Agents::PushoverAgent do
   before do

+ 1 - 1
spec/models/agents/rss_agent_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require 'rails_helper'
 
 describe Agents::RssAgent do
   before do

+ 1 - 1
spec/models/agents/scheduler_agent_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require 'rails_helper'
 
 describe Agents::SchedulerAgent do
   let(:valid_params) {

+ 1 - 1
spec/models/agents/sentiment_agent_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require 'rails_helper'
 
 describe Agents::SentimentAgent do
     before do

+ 1 - 1
spec/models/agents/shell_command_agent_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require 'rails_helper'
 
 describe Agents::ShellCommandAgent do
   before do

+ 1 - 1
spec/models/agents/slack_agent_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require 'rails_helper'
 
 describe Agents::SlackAgent do
   before(:each) do

+ 1 - 1
spec/models/agents/stubhub_agent_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require 'rails_helper'
 
 describe Agents::StubhubAgent do
 

+ 1 - 1
spec/models/agents/translation_agent_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require 'rails_helper'
 
 describe Agents::TranslationAgent do
     before do

+ 1 - 1
spec/models/agents/trigger_agent_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require 'rails_helper'
 
 describe Agents::TriggerAgent do
   before do

+ 1 - 1
spec/models/agents/tumblr_publish_agent_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require 'rails_helper'
 
 describe Agents::TumblrPublishAgent do
   before do

+ 1 - 1
spec/models/agents/twilio_agent_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require 'rails_helper'
 
 describe Agents::TwilioAgent do
   before do

+ 1 - 1
spec/models/agents/twitter_publish_agent_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require 'rails_helper'
 
 describe Agents::TwitterPublishAgent do
   before do

+ 1 - 1
spec/models/agents/twitter_search_agent_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require 'rails_helper'
 
 describe Agents::TwitterSearchAgent do
   before do

+ 1 - 1
spec/models/agents/twitter_stream_agent_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require 'rails_helper'
 
 describe Agents::TwitterStreamAgent do
   before do

+ 1 - 1
spec/models/agents/twitter_user_agent_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require 'rails_helper'
 
 describe Agents::TwitterUserAgent do
   before do

+ 1 - 1
spec/models/agents/user_location_agent_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require 'rails_helper'
 
 describe Agents::UserLocationAgent do
   before do

+ 1 - 1
spec/models/agents/weather_agent_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require 'rails_helper'
 
 describe Agents::WeatherAgent do
   let(:agent) do

+ 1 - 1
spec/models/agents/webhook_agent_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require 'rails_helper'
 
 describe Agents::WebhookAgent do
   let(:agent) do

+ 1 - 1
spec/models/agents/website_agent_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require 'rails_helper'
 
 describe Agents::WebsiteAgent do
   describe "checking without basic auth" do

+ 1 - 1
spec/models/agents/weibo_publish_agent_spec.rb

@@ -1,5 +1,5 @@
 # encoding: utf-8 
-require 'spec_helper'
+require 'rails_helper'
 
 describe Agents::WeiboPublishAgent do
   before do

+ 1 - 1
spec/models/agents/weibo_user_agent_spec.rb

@@ -1,5 +1,5 @@
 # encoding: utf-8 
-require 'spec_helper'
+require 'rails_helper'
 
 describe Agents::WeiboUserAgent do
   before do

+ 1 - 1
spec/models/agents/witai_agent_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require 'rails_helper'
 
 describe Agents::WitaiAgent do
   before do

+ 1 - 1
spec/models/agents/wunderlist_agent_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require 'rails_helper'
 require 'models/concerns/oauthable'
 
 describe Agents::WunderlistAgent do

+ 1 - 1
spec/models/concerns/oauthable.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require 'rails_helper'
 
 module Agents
   class OauthableTestAgent < Agent

+ 1 - 1
spec/models/event_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require 'rails_helper'
 
 describe Event do
   describe ".with_location" do

+ 1 - 1
spec/models/scenario_import_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require 'rails_helper'
 
 describe ScenarioImport do
   let(:user) { users(:bob) }

+ 1 - 1
spec/models/scenario_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require 'rails_helper'
 
 describe Scenario do
   let(:new_instance) { users(:bob).scenarios.build(:name => "some scenario") }

+ 1 - 1
spec/models/service_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require 'rails_helper'
 
 describe Service do
   before(:each) do

+ 8 - 8
spec/models/user_credential_spec.rb

@@ -1,19 +1,19 @@
-require 'spec_helper'
+require 'rails_helper'
 
 describe UserCredential do
   describe "validation" do
-    it { is_expected.to validate_uniqueness_of(:credential_name).scoped_to(:user_id) }
-    it { is_expected.to validate_presence_of(:credential_name) }
-    it { is_expected.to validate_presence_of(:credential_value) }
-    it { is_expected.to validate_presence_of(:user_id) }
+    it { should validate_uniqueness_of(:credential_name).scoped_to(:user_id) }
+    it { should validate_presence_of(:credential_name) }
+    it { should validate_presence_of(:credential_value) }
+    it { should validate_presence_of(:user_id) }
   end
 
   describe "mass assignment" do
-    it { is_expected.to allow_mass_assignment_of :credential_name }
+    it { should allow_mass_assignment_of :credential_name }
 
-    it { is_expected.to allow_mass_assignment_of :credential_value }
+    it { should allow_mass_assignment_of :credential_value }
 
-    it { is_expected.not_to allow_mass_assignment_of :user_id }
+    it { should_not allow_mass_assignment_of :user_id }
   end
 
   describe "cleaning fields" do

+ 4 - 4
spec/models/users_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require 'rails_helper'
 
 describe User do
   describe "validations" do
@@ -10,13 +10,13 @@ describe User do
         
         it "only accepts valid invitation codes" do
           User::INVITATION_CODES.each do |v|
-            is_expected.to allow_value(v).for(:invitation_code)
+            should allow_value(v).for(:invitation_code)
           end
         end
   
         it "can reject invalid invitation codes" do
           %w['foo', 'bar'].each do |v|
-            is_expected.not_to allow_value(v).for(:invitation_code)
+            should_not allow_value(v).for(:invitation_code)
           end
         end
       end
@@ -28,7 +28,7 @@ describe User do
         
         it "skips this validation" do
           %w['foo', 'bar', nil, ''].each do |v|
-            is_expected.to allow_value(v).for(:invitation_code)
+            should allow_value(v).for(:invitation_code)
           end
         end
       end

+ 1 - 1
spec/presenters/form_configurable_agent_presenter_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require 'rails_helper'
 
 describe FormConfigurableAgentPresenter do
   include RSpecHtmlMatchers

+ 7 - 5
spec/spec_helper.rb → spec/rails_helper.rb

@@ -21,11 +21,13 @@ Dir[Rails.root.join("spec/support/**/*.rb")].each { |f| require f }
 
 ActiveRecord::Migration.maintain_test_schema!
 
-# TODO: This will silence warnings when the raise_error matcher
-# is used without providing a specific error or error message.
-# Specs SHOULD pass the type of error that you're expecting to be
-# raised when using the raise_error matcher.
-RSpec::Expectations.configuration.warn_about_potential_false_positives = false
+# Mix in shoulda matchers
+Shoulda::Matchers.configure do |config|
+  config.integrate do |with|
+    with.test_framework :rspec
+    with.library :rails
+  end
+end
 
 RSpec.configure do |config|
   config.mock_with :rr

+ 1 - 1
spec/routing/webhooks_controller_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require 'rails_helper'
 
 describe "routing for web requests", :type => :routing do
   it "routes to handle_request" do

+ 1 - 1
spec/support/shared_examples/agent_controller_concern.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require 'rails_helper'
 
 shared_examples_for AgentControllerConcern do
   describe "preconditions" do

+ 1 - 1
spec/support/shared_examples/email_concern.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require 'rails_helper'
 
 shared_examples_for EmailConcern do
   let(:valid_options) {

+ 1 - 1
spec/support/shared_examples/has_guid.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require 'rails_helper'
 
 shared_examples_for HasGuid do
   it "gets created before_save, but only if it's not present" do

+ 2 - 2
spec/support/shared_examples/liquid_interpolatable.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require 'rails_helper'
 
 shared_examples_for LiquidInterpolatable do
   before(:each) do
@@ -94,7 +94,7 @@ shared_examples_for LiquidInterpolatable do
       it "should raise an exception for undefined credentials" do
         expect {
           @checker.interpolate_string("{% credential unknown %}", {})
-        }.to raise_error
+        }.to raise_error(/No user credential named/)
       end
     end
 

+ 1 - 1
spec/support/shared_examples/web_request_concern.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require 'rails_helper'
 
 shared_examples_for WebRequestConcern do
   let(:agent) do

Some files were not shown because too many files changed in this diff