Przeglądaj źródła

Moved the _get_question_links logic outside of get_links_at_pos

a.jha 9 lat temu
rodzic
commit
0db34e8d6f
2 zmienionych plików z 6 dodań i 2 usunięć
  1. 5 1
      howdoi/howdoi.py
  2. 1 1
      test_howdoi.py

+ 5 - 1
howdoi/howdoi.py

@@ -136,8 +136,12 @@ def _format_output(code, args):
                      TerminalFormatter(bg='dark'))
 
 
+def _get_question_links(links):
+    return [link for link in links if _is_question(link)]
+
+
 def _get_answer(args, links):
-    links = [link for link in links if _is_question(link)]
+    links = _get_question_links(links)
     link = get_link_at_pos(links, args['pos'])
     if not link:
         return False

+ 1 - 1
test_howdoi.py

@@ -34,7 +34,7 @@ class HowdoiTestCase(unittest.TestCase):
         self.assertEqual(howdoi.get_link_at_pos(['/questions/42/'], 2),
                          '/questions/42/')
         self.assertEqual(howdoi.get_link_at_pos(['/howdoi', '/questions/42/'], 1),
-                         '/questions/42/')
+                         '/howdoi')
         self.assertEqual(howdoi.get_link_at_pos(['/howdoi', '/questions/42/'], 2),
                          '/questions/42/')
         self.assertEqual(howdoi.get_link_at_pos(['/questions/42/', '/questions/142/'], 1),