Browse Source

Fix `@Transactional` invalid cases (#4551)

* 1、fix transcation invalid

* 1、fix assignNamespaceRoleToConsumer transcation isvalid

* Fix assignNamespaceRoleToConsumer transcation invalid

* 1、Fix `@Transactional` invalid

Co-authored-by: Jason Song <nobodyiam@gmail.com>
ksice 2 years ago
parent
commit
b344d54499

+ 2 - 2
apollo-biz/src/main/java/com/ctrip/framework/apollo/biz/service/AuditService.java

@@ -41,7 +41,7 @@ public class AuditService {
   }
 
   @Transactional
-  void audit(String entityName, Long entityId, Audit.OP op, String owner) {
+  public void audit(String entityName, Long entityId, Audit.OP op, String owner) {
     Audit audit = new Audit();
     audit.setEntityName(entityName);
     audit.setEntityId(entityId);
@@ -51,7 +51,7 @@ public class AuditService {
   }
 
   @Transactional
-  void audit(Audit audit){
+  public void audit(Audit audit){
     auditRepository.save(audit);
   }
 }

+ 1 - 0
apollo-portal/src/main/java/com/ctrip/framework/apollo/portal/service/AppNamespaceService.java

@@ -118,6 +118,7 @@ public class AppNamespaceService {
     return Objects.isNull(appNamespaceRepository.findByAppIdAndName(appId, namespaceName));
   }
 
+  @Transactional
   public AppNamespace createAppNamespaceInLocal(AppNamespace appNamespace) {
     return createAppNamespaceInLocal(appNamespace, true);
   }

+ 1 - 1
apollo-portal/src/main/java/com/ctrip/framework/apollo/portal/spi/defaultimpl/DefaultRoleInitializationService.java

@@ -143,7 +143,7 @@ public class DefaultRoleInitializationService implements RoleInitializationServi
   }
 
   @Transactional
-  private void createManageAppMasterRole(String appId, String operator) {
+  public void createManageAppMasterRole(String appId, String operator) {
     Permission permission = createPermission(appId, PermissionType.MANAGE_APP_MASTER, operator);
     rolePermissionService.createPermission(permission);
     Role role = createRole(RoleUtils.buildAppRoleName(appId, PermissionType.MANAGE_APP_MASTER), operator);