浏览代码

Don't open the quickfix window after fixit

Ben Jackson 7 年之前
父节点
当前提交
dc52b73048
共有 3 个文件被更改,包括 4 次插入16 次删除
  1. 4 4
      README.md
  2. 0 11
      python/ycm/tests/vimsupport_test.py
  3. 0 1
      python/ycm/vimsupport.py

+ 4 - 4
README.md

@@ -1766,10 +1766,10 @@ manually saved. A confirmation dialog is opened prior to doing this to remind
 you that this is about to happen.
 you that this is about to happen.
 
 
 Once the modifications have been made, the quickfix list (see `:help quickfix`)
 Once the modifications have been made, the quickfix list (see `:help quickfix`)
-is opened and populated with the locations of all modifications. This can be
-used to review all automatic changes made. Typically, use the `CTRL-W
-<enter>` combination to open the selected file in a new split. It is possible
-to customize how the quickfix window is opened by using [the `YcmQuickFixOpened`
+is populated with the locations of all modifications. This can be used to review
+all automatic changes made by using `:copen`. Typically, use the `CTRL-W
+<enter>` combination to open the selected file in a new split. It is possible to
+customize how the quickfix window is opened by using [the `YcmQuickFixOpened`
 autocommand](#the-ycmquickfixopened-autocommand).
 autocommand](#the-ycmquickfixopened-autocommand).
 
 
 The buffers are *not* saved automatically. That is, you must save the modified
 The buffers are *not* saved automatically. That is, you must save the modified

+ 0 - 11
python/ycm/tests/vimsupport_test.py

@@ -719,11 +719,6 @@ def ReplaceChunks_SingleFile_Open_test( vim_command,
       'type': 'F'
       'type': 'F'
     } ] ) ) ),
     } ] ) ) ),
   ] )
   ] )
-  vim_command.assert_has_exact_calls( [
-    call( 'botright copen' ),
-    call( 'silent! wincmd p' )
-  ] )
-  set_fitting_height.assert_called_once_with()
 
 
   # And it is ReplaceChunks that prints the message showing the number of
   # And it is ReplaceChunks that prints the message showing the number of
   # changes
   # changes
@@ -817,10 +812,7 @@ def ReplaceChunks_SingleFile_NotOpen_test( vim_command,
   vim_command.assert_has_exact_calls( [
   vim_command.assert_has_exact_calls( [
     call( 'lclose' ),
     call( 'lclose' ),
     call( 'hide' ),
     call( 'hide' ),
-    call( 'botright copen' ),
-    call( 'silent! wincmd p' )
   ] )
   ] )
-  set_fitting_height.assert_called_once_with()
 
 
   # And update the quickfix list
   # And update the quickfix list
   vim_eval.assert_has_exact_calls( [
   vim_eval.assert_has_exact_calls( [
@@ -1202,10 +1194,7 @@ def ReplaceChunks_MultiFile_Open_test( vim_command,
   vim_command.assert_has_exact_calls( [
   vim_command.assert_has_exact_calls( [
     call( 'lclose' ),
     call( 'lclose' ),
     call( 'hide' ),
     call( 'hide' ),
-    call( 'botright copen' ),
-    call( 'silent! wincmd p' )
   ] )
   ] )
-  set_fitting_height.assert_called_once_with()
 
 
   # And update the quickfix list with each entry
   # And update the quickfix list with each entry
   vim_eval.assert_has_exact_calls( [
   vim_eval.assert_has_exact_calls( [

+ 0 - 1
python/ycm/vimsupport.py

@@ -832,7 +832,6 @@ def ReplaceChunks( chunks, silent=False ):
   if not silent:
   if not silent:
     if locations:
     if locations:
       SetQuickFixList( locations )
       SetQuickFixList( locations )
-      OpenQuickFixList()
 
 
     PostVimMessage( 'Applied {0} changes'.format( len( chunks ) ),
     PostVimMessage( 'Applied {0} changes'.format( len( chunks ) ),
                     warning = False )
                     warning = False )